forked from kubernetes-sigs/controller-runtime
-
Notifications
You must be signed in to change notification settings - Fork 16
✨ Rebase to 0.19 #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sttts
merged 9 commits into
kcp-dev:kcp-0.19
from
tnthornton:tnthornton-kcp-0.19-take-2
Sep 23, 2024
Merged
✨ Rebase to 0.19 #60
sttts
merged 9 commits into
kcp-dev:kcp-0.19
from
tnthornton:tnthornton-kcp-0.19-take-2
Sep 23, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0479fc7
to
94127e1
Compare
94127e1
to
e744ff6
Compare
Signed-off-by: tnthornton <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
e744ff6
to
bc184ec
Compare
/retest |
bc184ec
to
dbdecbc
Compare
Signed-off-by: tnthornton <[email protected]>
dbdecbc
to
73cc71a
Compare
Signed-off-by: tnthornton <[email protected]>
40ca541
to
0f609a8
Compare
sttts
approved these changes
Sep 23, 2024
LGTM label has been added. Git tree hash: 2b2452f8a01227c9ad9af3791f086f6bbdec1c57
|
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dco-signoff: yes
Indicates the PR's author has signed the DCO.
lgtm
Indicates that a PR is ready to be merged.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased kcp-0.18 on top of kcp-0.19 (currently the branch from upstream).
This is currently needed for two reasons:
Pull in lastest changes from controller-runtime.
There was a signature change in utilruntime.PanicHandlers (0.31.0)
NOTE: supersedes #59